Modify

Ticket #23 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

Wiki link to user profile is red despite completed user profile

Reported by: Andreas.rindler Owned by: Xiping.Wang
Priority: trivial Milestone: 1.1
Component: Wiki Version: 1.0
Keywords: social profile, wiki Cc:
Actual Effort (in hours): Estimated Effort (in hours):

Description

Because omCollab uses the Social Profile extension, users don't edit their wiki user page anymore, but rather complete their social profile. Links (like [[User:User.Name]] appear in red, because Mediawiki has an empty wiki page and doesn't look at the social profile page.

Need to show regular link if link is user link. There is no need anymore to show red links on user links.

Attachments

ticket_23.png Download (23.2 KB) - added by Xiping.Wang 3 years ago.
the difference of the two user links - the patch works for the link in the wiki page not the sidebar

Change History

comment:1 Changed 4 years ago by Andreas.rindler

  • Milestone set to 1.1

comment:2 Changed 3 years ago by Sean.McClowry

  • Owner changed from admin to Xiping.Wang

comment:4 Changed 3 years ago by Sean.McClowry

Sounds good - our task to upgrade to MW 1.14 will therefore be a dependency ..

Changed 3 years ago by Xiping.Wang

the difference of the two user links - the patch works for the link in the wiki page not the sidebar

comment:5 Changed 3 years ago by Xiping.Wang

The quick and dirty fix is to modify Linker.php's makeBrokenLinkerObj to ignore User links. It works absolutely.

The perfect idea is:

1.determind if there is socialprofile installed( How to?)

2.add NS_USER process in Parse.php's replaceInternalLinks function

//line:1787
}elseif( $ns == NS_USER ) {
   $s .= $this->makeKnownLinkHolder( $nt, $text, '', $trail, $prefix );
   $this->mOutput->addLink( $nt );
   continue;
}
  1. Other process?

I found there is a difference between of the User link of the sidebar. Check the attached picture.Need to check the sidebar code.

comment:6 follow-up: ↓ 7 Changed 3 years ago by Sean.McClowry

if we ignore links does that mean cannot wikilink to /wiki/User:name on any page?

Generally we do not like to change the mediawiki core. One option could be to make this patch part of a local deploy process, which could also check to see if socialprofile is installed ...

That is strange that the patch only works for the wiki page. The sidebar is possibly more important as the user is more likely to see it. Any chance it is because the portlet is not refreshed?

comment:7 in reply to: ↑ 6 Changed 3 years ago by Xiping.Wang

Replying to Sean.McClowry:

if we ignore links does that mean cannot wikilink to /wiki/User:name on any page?

We just treat all user page as the known blue links. So it still works. Yes, I don't want to follow this way too. You know, the next upgrading job is painful for me.:-)

comment:8 Changed 3 years ago by Xiping.Wang

  • Status changed from new to closed
  • Resolution set to fixed

fixed on SocilaProfile? extension.

The patch is based on the hook of MW 1.14.0.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.